<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/27/2013 10:03 AM, Tomas Babej
wrote:<br>
</div>
<blockquote cite="mid:51A3134B.2060502@redhat.com" type="cite">On
05/26/2013 08:56 PM, Alexander Bokovoy wrote:
<br>
<blockquote type="cite">On Fri, 24 May 2013, Tomas Babej wrote:
<br>
<blockquote type="cite">On 05/20/2013 04:29 PM, Alexander
Bokovoy wrote:
<br>
<blockquote type="cite">On Mon, 20 May 2013, Tomas Babej
wrote:
<br>
<blockquote type="cite">On 05/16/2013 11:16 AM, Ana
Krivokapic wrote:
<br>
<blockquote type="cite">On 05/15/2013 03:41 PM, Tomas
Babej wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
When removing an ID range using idrange-del command,
validation
<br>
in pre_callback ensures that the range does not belong
to any
<br>
active trust. In such case, ValidationError is raised.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/3615">https://fedorahosted.org/freeipa/ticket/3615</a>
<br>
<br>
Tomas
<br>
<br>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
<br>
I suggest adding some unit tests to cover this change in
functionality.
<br>
<br>
-- <br>
Regards,
<br>
<br>
Ana Krivokapic
<br>
Associate Software Engineer
<br>
FreeIPA team
<br>
Red Hat Inc.
<br>
<br>
<br>
_______________________________________________
<br>
Freeipa-devel mailing list
<br>
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<br>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a>
<br>
</blockquote>
<br>
I incorporated the unit tests. It had to use direct access
to LDAP using ldapmodify since we need to create a mock AD
trusted range first.
<br>
<br>
Tomas
<br>
</blockquote>
<br>
</blockquote>
We got rid of openldap utilities now. While using python.ldap
module, I also made the tests much more robust and added a new
test case.
<br>
</blockquote>
In general patches look fine, there is one small nitpick.
<br>
I'll run tests on Monday and then will provide final ACK.
<br>
<br>
<blockquote type="cite">---
a/tests/test_xmlrpc/test_range_plugin.py
<br>
+++ b/tests/test_xmlrpc/test_range_plugin.py
<br>
@@ -22,66 +22,171 @@ Test the `ipalib/plugins/idrange.py`
module, and XML-RPC in general.
<br>
"""
<br>
<br>
from ipalib import api, errors, _
<br>
+from ipapython.ipautil import run
<br>
</blockquote>
This import is unused, can be removed.
<br>
<br>
</blockquote>
Fixed, thanks for catching that.
<br>
<br>
Updated patch attached.
<br>
<br>
Tomas
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Additionally, I removed one redundant variable upon further review.<br>
<br>
Tomas<br>
</body>
</html>