<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/28/2013 03:48 PM, Alexander
Bokovoy wrote:<br>
</div>
<blockquote cite="mid:20130528134833.GX26689@redhat.com" type="cite">On
Tue, 28 May 2013, Tomas Babej wrote:
<br>
<blockquote type="cite">On 05/28/2013 02:35 PM, Alexander Bokovoy
wrote:
<br>
<blockquote type="cite">On Mon, 27 May 2013, Tomas Babej wrote:
<br>
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">
<blockquote type="cite">We got rid of openldap utilities
now. While using python.ldap module, I also made the
tests much more robust and added a new test case.
<br>
</blockquote>
In general patches look fine, there is one small
nitpick.
<br>
I'll run tests on Monday and then will provide final
ACK.
<br>
<br>
<blockquote type="cite">---
a/tests/test_xmlrpc/test_range_plugin.py
<br>
+++ b/tests/test_xmlrpc/test_range_plugin.py
<br>
@@ -22,66 +22,171 @@ Test the
`ipalib/plugins/idrange.py` module, and XML-RPC in
general.
<br>
"""
<br>
<br>
from ipalib import api, errors, _
<br>
+from ipapython.ipautil import run
<br>
</blockquote>
This import is unused, can be removed.
<br>
<br>
</blockquote>
Fixed, thanks for catching that.
<br>
<br>
Updated patch attached.
<br>
</blockquote>
</blockquote>
So I tried to run this test on a machine where there is
already trust
<br>
established and I think there should be done some changes.
<br>
</blockquote>
<br>
I perused the log. Seems that the failures you're experiencing
are not relevant to the patch itself,
<br>
since the newly added tests passed.
<br>
<br>
This is problem with test_range_plugin.py tests that has been
there for quite a while, the parameters
<br>
of the ranges such as size, and base ID/RID/secondary RID are
hardcoded in the test case.
<br>
</blockquote>
Yep.
<br>
<br>
<br>
<blockquote type="cite">
<blockquote type="cite">Probably it would be wise to add
pre-start procedure to pull existing
<br>
ranges and define constants for the ranges so that they don't
overlap
<br>
with existing ones. Perhaps selecting something from a top of
the range
<br>
space...
<br>
<br>
Attached is the log
<br>
</blockquote>
<br>
I agree. This has not been relevant until now, since we did not
do much testing on IPA instances
<br>
with trusts set up, and even then there's random factor in
having the overlap with the already created
<br>
trust range.
<br>
<br>
I'd propose fixing this in a separate effort as a part of
continouous integration improvements. I see it
<br>
as a separate issue of its own.
<br>
<br>
What do you think?
<br>
</blockquote>
Please file a separate ticket then.
<br>
<br>
ACK for this one.
<br>
<br>
</blockquote>
For the record:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="https://fedorahosted.org/freeipa/ticket/3662">https://fedorahosted.org/freeipa/ticket/3662</a><br>
<br>
Tomas<br>
</body>
</html>