<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 05/31/2013 12:51 PM, Tomas Babej
wrote:<br>
</div>
<blockquote cite="mid:51A880BF.2010108@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 05/31/2013 12:25 PM, Tomas Babej
wrote:<br>
</div>
<blockquote cite="mid:51A87A9E.2040404@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 05/29/2013 03:24 PM, Ana
Krivokapic wrote:<br>
</div>
<blockquote cite="mid:51A60199.5000009@redhat.com" type="cite">
<pre wrap="">Hello,
This patch addresses ticket <a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/3636">https://fedorahosted.org/freeipa/ticket/3636</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
I edited your patch to use newly introduced prompt_param method
as agreed in my patches 53-55 thread.<br>
<br>
The functional part itself looks good, the tests though, are
dependent on the environment. The particular<br>
code branch of tests that is being executed depends on the fact
whether any trust is estabilished on that<br>
particular FreeIPA instance the test suite is being run on.<br>
<br>
I suggest you create a mock trust LDAP entry as in my patch 57
that has been just pushed to master,<br>
and test both cases (whether the interactive prompt behaves
correctly both with the trust estabilished <br>
and without it).<br>
<br>
Maybe we should move the setUpClass/tearDownClass logic to
tests/util.py to avoid code duplication.<br>
<br>
Attaching the updated patch (apply on top of tbabej-55-3).<br>
<br>
Tomas<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Wrong thread, sorry. This applies to patch 30.<br>
<br>
Tomas<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
<br>
</blockquote>
I tested the *patch 31*, both with new and old client, works fine.<br>
<br>
ACK<br>
<br>
Tomas<br>
</body>
</html>