<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 06/13/2013 03:24 PM, Petr Vobornik
      wrote:<br>
    </div>
    <blockquote cite="mid:51B9C81F.8030508@redhat.com" type="cite">On
      06/13/2013 02:46 PM, Ana Krivokapic wrote:
      <br>
      <blockquote type="cite">On 06/13/2013 12:30 PM, Petr Vobornik
        wrote:
        <br>
        <blockquote type="cite">Rule tables with external member has
          more than one column and
          <br>
          therefore exclude parameter for adder dialog is not array of
          strings
          <br>
          but array of objects. normalize_values function can't work
          with it and
          <br>
          causes JS error.
          <br>
          <br>
          This patch creates proper exclude array before passing it to
          adder
          <br>
          dialog.
          <br>
          <br>
          <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/3711">https://fedorahosted.org/freeipa/ticket/3711</a>
          <br>
        </blockquote>
      </blockquote>
      <br>
      <blockquote type="cite">ACK
        <br>
        <br>
        <br>
      </blockquote>
      <br>
      I've noticed that there is a leftover from a different approach:
      <br>
      <br>
                   pkey: pkey,
      <br>
      +            param: that.name,
      <br>
                   other_entity: that.other_entity,
      <br>
      <br>
      The line is removed, updated patch attached.
      <br>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
    </blockquote>
    <br>
    I missed it too in the first patch. ACK for updated patch.<br>
    <br>
    <pre class="moz-signature" cols="80">-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.</pre>
  </body>
</html>