<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 10/16/2013 01:57 PM, Petr Viktorin wrote: </div> <blockquote cite="mid:525E7F36.4000507@redhat.com" type="cite">On 10/14/2013 04:28 PM, Tomas Babej wrote: <blockquote type="cite">Hi, When trying to create a new ordered test case by inheriting from already defined test case, by overriding few of its methods, the execution order of the tests is as follows: - first all non-overriden test methods from the parent test class - then all overriden tests methods </blockquote> That is not strictly true: if the base class is defined in a different file, with larger line numbers, with this patch its tests would run last. <blockquote type="cite">This patch makes sure that methods are executed in the logical order, that is, the order defined in the parent class. </blockquote> We'll also need to support longer inheritance chains than just one parent. The sort should look at the first @ordered superclass where the method was defined, and run the methods defined at the beginning of the inheritance chain first. I've modified your patch to accomplish this, does it look OK? </blockquote> Thanks! This will even work with cross-module imports. I added a section to the Integration testing design page: <meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"> <a href="http://www.freeipa.org/page/V3/Integration_testing#Ordering_of_the_tests">http://www.freeipa.org/page/V3/Integration_testing#Ordering_of_the_tests</a> Also, I changed the commit message and comments to reflect the new behaviour. Updated patch attached. Tomas <pre class="moz-signature" cols="72">-- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org</pre> </body> </html>