<html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 09/30/2013 05:05 PM, Petr Viktorin wrote: </div> <blockquote cite="mid:5249932F.10409@redhat.com" type="cite">Hello, This patch introduces an user "template" with the result of a default user add/show. The template is then customized and used in each test. This makes the tests shorter, and highlights the "non-default" (interesting) pieces of the result instead of presenting a wall of text. Also, when a new default attribute is added to user results (as is the case in my upcoming ACI patches), there's now only one place to change. <fieldset class="mimeAttachmentHeader"></fieldset> <pre wrap="">_______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre> </blockquote> ACK with two tiny nitpicks: <pre wrap="">+ Attributes named in ``omit`` are removed from the result; any additional + or non-default values can be specified in``overrides``. ^^^^^ missing space + """ + # sn can be None; this should only used from `get_admin_result` ... this should only *be* used ... </pre> <pre class="moz-signature" cols="80">-- Regards, Ana Krivokapic Associate Software Engineer FreeIPA team Red Hat Inc.</pre> </body> </html>