<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 12/05/2013 01:37 PM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:52A0738E.60302@redhat.com" type="cite">Consider
this scenario:
<br>
<br>
- Nathaniel submits RADIUS patches that update the API version
(from 2.69 to 2.70)
<br>
- I have ACI patches that also bump the version (from 2.69 to
2.70)
<br>
- Nathaniel's patches gets accepted
<br>
- I rebase my ACI patches onto master. Git thinks that the
2.69->2.70 change is already done, so it leaves VERSION
unchanged.
<br>
<br>
I can solve this locally by telling Git to not merge VERSION
automatically, but I think it would be helpful to add a unique
comment to each change so that everyone gets a conflict cases like
this.
<br>
Do you agree?
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
Makes sense to me.<br>
<br>
I'd just add a comment so that the purpose of the last change
comment is also obvious for the new developer perusing the VERSION
file.<br>
<br>
Maybe something along the lines of:<br>
<br>
########################################################<br>
IPA_API_VERSION_MAJOR=2<br>
IPA_API_VERSION_MINOR=70<br>
+# Update the last change entry to enforce conflict on merging two
independent branches into master.<br>
+# Last change: npmccallum - RADIUS support<br>
<br>
<pre class="moz-signature" cols="72">--
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org</pre>
</body>
</html>