<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Also I made explicit conversion to list for default values upon
Petr's request.<br>
<br>
<div class="moz-cite-prefix">On 09/04/2014 12:32 PM, Tomas Babej
wrote:<br>
</div>
<blockquote cite="mid:54083FC6.5050001@redhat.com" type="cite">
<pre wrap="">
On 09/03/2014 04:53 PM, Petr Viktorin wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 09/03/2014 03:53 PM, Tomas Babej wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi,
Makes sure that any new sources added are not already present
in the entry.
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4508">https://fedorahosted.org/freeipa/ticket/4508</a>
</pre>
</blockquote>
<pre wrap="">
It works fine, ACK.
I do have some comments, but 4.0.x is a stabilization release, so
they'd probably be better in a 4.1 patch:
The way you first join default_value to make configured_services, and
then repeatedly split it, looks quite wasteful. Wouldn't
configured_services be better as a list?
</pre>
</blockquote>
<pre wrap="">
Yes, the string handling was kind of unfortunate. I fixed it in this
iteration of the patch.
</pre>
<blockquote type="cite">
<pre wrap="">Also I wonder if configure_nsswitch_database needs those unused
preserve/append options.
</pre>
</blockquote>
<pre wrap="">
Although not used yet, I think it's handy to have them there, they do
not complicate the code much.
</pre>
<blockquote type="cite">
<pre wrap="">
Should I push now?
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org </pre>
</body>
</html>