<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 02/09/14 11:59, Martin Basti wrote:<br>
</div>
<blockquote cite="mid:540594F3.2030001@redhat.com" type="cite">On
02/09/14 09:10, Jan Cholasta wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Dne 1.9.2014 v 16:57 Martin Basti napsal(a):
<br>
<blockquote type="cite">This patch allows to disable service in
LDAP to prevents service to be
<br>
started by "ipactl restart"
<br>
<br>
Required by DNSSEC
<br>
<br>
Patch attached
<br>
</blockquote>
<br>
I don't think the extra argument in ldap_enable is necessary. It
should enable the service no matter if the entry existed before
or not.
<br>
<br>
Similarly, in ldap_disable you should not raise an error when
the entry is not found, because that already makes the service
disabled.
<br>
<br>
Honza
<br>
<br>
</blockquote>
Updated patch attached
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
Please review, this should be in 4.1<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>