<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 08/26/2014 01:16 PM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:53FC6C74.1060907@redhat.com" type="cite">On
07/30/2014 04:26 PM, Petr Viktorin wrote:
<br>
<blockquote type="cite">On 07/29/2014 06:03 PM, Petr Viktorin
wrote:
<br>
<blockquote type="cite">On 07/29/2014 05:02 PM, Petr Viktorin
wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
The first patch here consolidates our system user creation
code a bit.
<br>
<br>
The second patch fixes an oversight in the restore script.
<br>
<br>
The third changes the backup script to not include
/etc/{passwd,group},
<br>
and the restore script to create the PKI user if a CA is
being restored.
<br>
Note that the DS user is already created early in the
restore process.
<br>
(In the future we may want a nice generic framework for
restoring users,
<br>
but I'd like to extrapolate from more than one data point
when designing
<br>
it.)
<br>
</blockquote>
<br>
Another note: tar uses owner user/group names by default, so
no
<br>
additional chowning is required even if the IDs change between
backup &
<br>
restore.
<br>
<br>
<blockquote type="cite">
<br>
The fourth patch adds a log entry I find very useful in
testing
<br>
backup/restore.
<br>
</blockquote>
</blockquote>
<br>
<br>
Rebased onto current master.
<br>
</blockquote>
<br>
Rebased again.
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
I like the approach, solves the issue quite neatly. I didn't find
any issues in the changes themselves, or during the testing, so ACK
from me for the whole patcheset (which means patches 624-627,
despite the subject).<br>
<br>
<pre class="moz-signature" cols="72">--
Tomas Babej
Associate Software Engineer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org </pre>
</body>
</html>