<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 08/15/2014 10:40 PM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:53EE7049.3050605@redhat.com" type="cite">A fix
for <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4157">https://fedorahosted.org/freeipa/ticket/4157</a>
<br>
<br>
This depends on my patches 0631-0632 (for backup/restore
integration tests).
<br>
<br>
<br>
Our setsebool code was repeated a few times. Instead of adding
another copy, I refactored what we have into a platform task.
<br>
I fixed two old setsebool tickets while I was at it:
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/2519">https://fedorahosted.org/freeipa/ticket/2519</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/2934">https://fedorahosted.org/freeipa/ticket/2934</a>
<br>
<br>
Since ipaplatform should not depend on ipalib, and I needed a new
exception type, I added a new module, ipapython.errors. This might
not be the best name, since it could be confused with
ipalib.errors. Opinions welcome.
<br>
<br>
<br>
As for the second patch: ideally, rather than what I do with `if
'ADTRUST' in self.backup_services`, we'd get the list of booleans
directly from the *instance modules, or even tell the individual
services to restore themselves. But, that refactoring looks like
too much to do now.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<font face="Times New Roman, Times, serif"><br>
The first patch looks good to me. Just a minor comment. The test
and run of 'paths.SELINUXENABLED' is present several times in
tasks.py and fedora. Does it worth to refactor it ?<br>
<br>
About the second patch, something I do not understand.
restore_selinux_booleans resets the selinux boolean to the values
that are taken from </font><font face="Times New Roman, Times,
serif"><font face="Times New Roman, Times, serif">SELINUX_BOOLEAN_SETTINGS
</font>in the instance (http/ad) . Does that mean this dict has
been updated with the original values (using 'backup_func' in
set_selinux_booleans ?).<br>
<br>
<br>
thanks<br>
thierry<br>
</font>
</body>
</html>