<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/25/2014 10:58 AM, Petr Viktorin
wrote:<br>
</div>
<blockquote cite="mid:5423D91C.6040503@redhat.com" type="cite">On
09/24/2014 06:02 PM, thierry bordaz wrote:
<br>
<blockquote type="cite">On 08/15/2014 10:40 PM, Petr Viktorin
wrote:
<br>
<blockquote type="cite">A fix for
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4157">https://fedorahosted.org/freeipa/ticket/4157</a>
<br>
<br>
This depends on my patches 0631-0632 (for backup/restore
integration
<br>
tests).
<br>
<br>
<br>
Our setsebool code was repeated a few times. Instead of adding
another
<br>
copy, I refactored what we have into a platform task.
<br>
I fixed two old setsebool tickets while I was at it:
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/2519">https://fedorahosted.org/freeipa/ticket/2519</a>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/2934">https://fedorahosted.org/freeipa/ticket/2934</a>
<br>
<br>
Since ipaplatform should not depend on ipalib, and I needed a
new
<br>
exception type, I added a new module, ipapython.errors. This
might not
<br>
be the best name, since it could be confused with
ipalib.errors.
<br>
Opinions welcome.
<br>
<br>
<br>
As for the second patch: ideally, rather than what I do with
`if
<br>
'ADTRUST' in self.backup_services`, we'd get the list of
booleans
<br>
directly from the *instance modules, or even tell the
individual
<br>
services to restore themselves. But, that refactoring looks
like too
<br>
much to do now.
<br>
</blockquote>
</blockquote>
<br>
Filed easyfix: <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4571">https://fedorahosted.org/freeipa/ticket/4571</a>
<br>
<br>
<br>
<blockquote type="cite">The first patch looks good to me. Just a
minor comment. The test and run
<br>
of 'paths.SELINUXENABLED' is present several times in tasks.py
and
<br>
fedora. Does it worth to refactor it ?
<br>
<br>
About the second patch, something I do not understand.
<br>
restore_selinux_booleans resets the selinux boolean to the
values that
<br>
are taken from SELINUX_BOOLEAN_SETTINGS in the instance
(http/ad) . Does
<br>
that mean this dict has been updated with the original values
(using
<br>
'backup_func' in set_selinux_booleans ?).
<br>
</blockquote>
<br>
This is restoring an IPA installation, not restoring the system to
a pre-IPA state.
<br>
The settings need to be the same as if IPA was being installed.
<br>
<br>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">OK thanks for the
explanation.</font><br>
</body>
</html>