<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This should be the final one.<br>
<br>
fm<br>
<div class="moz-cite-prefix"><br>
On 26/09/2014 16:30, Francesco Marella wrote:<br>
</div>
<blockquote cite="mid:54257893.9010607@gmx.com" type="cite">
<br>
On 26/09/2014 15:41, Petr Viktorin wrote:
<br>
<blockquote type="cite">
<br>
Hello! Thanks for the patch!
<br>
<br>
The new function is not one of the platform-independent tasks,
and doesn't even use `self`, so you can define it as a
module-level helper function.
<br>
<br>
But more importantly, this won't work: the blocks you are
replacing return from their functions. You'd need to use
something like:
<br>
if not selinux_enabled():
<br>
return
<br>
instead of:
<br>
self.check_enabled_selinux()
<br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</body>
</html>