<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/26/2014 05:53 PM, Francesco
Marella wrote:<br>
</div>
<blockquote cite="mid:54258BF0.4020208@gmx.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 26/09/2014 17:43, thierry bordaz
wrote:<br>
</div>
<blockquote cite="mid:542589B7.9060104@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hello,<br>
<br>
<blockquote>When called from set_selinux_booleans, if not
selinux_enabled, you may want to 'return False' rather than
'return'.<br>
Now it looks like callers of set_selinux_booleans do not
check the returned value <span class="moz-smiley-s1"><span>
:-) </span></span><br>
<br>
thanks<br>
thierry<br>
</blockquote>
On 09/26/2014 05:26 PM, Francesco Marella wrote:<br>
</div>
<blockquote cite="mid:542585B2.8020600@gmx.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
This should be the final one.<br>
<br>
fm<br>
<div class="moz-cite-prefix"><br>
On 26/09/2014 16:30, Francesco Marella wrote:<br>
</div>
<blockquote cite="mid:54257893.9010607@gmx.com" type="cite"> <br>
On 26/09/2014 15:41, Petr Viktorin wrote: <br>
<blockquote type="cite"> <br>
Hello! Thanks for the patch! <br>
<br>
The new function is not one of the platform-independent
tasks, and doesn't even use `self`, so you can define it
as a module-level helper function. <br>
<br>
But more importantly, this won't work: the blocks you are
replacing return from their functions. You'd need to use
something like: <br>
if not selinux_enabled(): <br>
return <br>
instead of: <br>
self.check_enabled_selinux() <br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Freeipa-devel mailing list
<a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a></pre>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Thanks Francesco !<br>
<br>
For me it is a ACK.<br>
<br>
thanks<br>
theirry<br>
</font>
</body>
</html>