<html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 09/29/2014 05:45 PM, Nathaniel McCallum wrote: </div> <blockquote cite="mid:1412005549.18502.2.camel@redhat.com" type="cite"> <pre wrap="">On Thu, 2014-09-25 at 13:45 +0200, thierry bordaz wrote: </pre> <blockquote type="cite"> <pre wrap="">On 09/19/2014 07:49 PM, Nathaniel McCallum wrote: </pre> <blockquote type="cite"> <pre wrap="">This is an optimization from patch 0062 (rescinded) which I think is worth keeping. There is no ticket for this. _______________________________________________ Freeipa-devel mailing list <a class="moz-txt-link-abbreviated" href="mailto:Freeipa-devel@redhat.com">Freeipa-devel@redhat.com</a> <a class="moz-txt-link-freetext" href="https://www.redhat.com/mailman/listinfo/freeipa-devel">https://www.redhat.com/mailman/listinfo/freeipa-devel</a> </pre> </blockquote> <pre wrap="">Hello, That is exact that slapi* are doing a intensive usage of the of alloc/free. Using a stack allocated mods would reduce the number of alloc/free but I afraid it will not have a significant impact. For example further slapi_modify_internal is doing tons of alloc/free. Also I think it is not possible to use stack allocated mods. In fact mods will be modified by internal_mod (for example to add 'modifytimestamp', 'modifiersname') and mods will be reallocated. This could also occurs from plugins. Finally if a modify retry occurs, the original mods are freeed. </pre> </blockquote> <pre wrap=""> See ldap/servers/slapd/task.c. In this file, everything is stack allocated except for the value itself. </pre> </blockquote> Hi Nathaniel, <blockquote>Yes you are correct. This is even a common method :-[ In fact the mods are duplicated/replaced by normalized one at the begining of modify_internal_pb. This is that duplicated ones that can later be extended/freed. Sorry for the noise. The fix is valid. Ack. thanks thierry </blockquote> </body> </html>