<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/29/2014 02:23 PM, Alexander
Bokovoy wrote:<br>
</div>
<blockquote cite="mid:20141029132335.GA5100@redhat.com" type="cite">On
Wed, 29 Oct 2014, thierry bordaz wrote:
<br>
<blockquote type="cite">The patches fixed the test case in
<a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1157989">https://bugzilla.redhat.com/show_bug.cgi?id=1157989</a>.
<br>
Few comments regarding the patch:
<br>
<br>
* in backend_search_cb, it checks if the search is in one of the
<br>
container. We need that cbdata.answer=FALSE at the end of the
checking.
<br>
Why not setting it systematically at the end.
<br>
</blockquote>
I've moved it to the end of the block.
<br>
<br>
<blockquote type="cite">* in backend_locate, 'target' is a
duplicate of cbdata.target. But
<br>
then when calling idview_replace_target_dn it may be changed.
<br>
Will not it lead to a leak ?
<br>
</blockquote>
Good catch, thanks!
<br>
<br>
Fixed version attached.
<br>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hi Alexander,<br>
<br>
The patches are good to me. Ack<br>
<br>
thanks<br>
thierry<br>
</font>
</body>
</html>