<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 2, 2015 at 8:59 AM, Martin Basti <span dir="ltr"><<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><div><div class="h5">
<div>On 30/03/15 15:25, Gabe Alford wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>Hello,<br>
<br>
</div>
With the merging of ticket <a href="https://fedorahosted.org/freeipa/ticket/4842" target="_blank">4842</a>,
I believe that half of ticket <a href="https://fedorahosted.org/freeipa/ticket/3092" target="_blank">3092</a>
has been done. This patch just adds a message that says that
NTP configuration was skipped which I believe should finish
<a href="https://fedorahosted.org/freeipa/ticket/3092" target="_blank">3092</a>.<br>
<br>
</div>
Thanks,<br>
<br>
</div>
Gabe<br>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote></div></div>
Hello, thank you for the patch.<br>
<br>
1)<br>
IMO there should be:<br>
if *not* options.conf_ntp<br></div></blockquote><div><br></div><div>So, if --no-ntp is not specified, print message that the client is skipping NTP sync?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000">
2)<br>
wouldnt be better to use just else?<span class="HOEnZb"><font color="#888888"><br></font></span></div></blockquote><div><br></div><div>I actually ran ipa-client-install with no options on a system where I used 'else', and it printed the skipping NTP sync when it should not have.<br></div><div>That is why the patch does not use 'else'.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><span class="HOEnZb"><font color="#888888">
<br>
Martin<br>
<pre cols="72">--
Martin Basti</pre>
</font></span></div>
</blockquote></div><br></div></div>