<div dir="ltr"><div class="gmail_extra">Stupid me. I realized that chronyd was running which messed up my testing and such (sorry about that). New patch attached that implements 'else'<br></div><div class="gmail_extra"><br>On Tue, Apr 7, 2015 at 2:32 AM, Martin Basti <span dir="ltr"><<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span class="">
<div>On 02/04/15 17:47, Gabe Alford wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Thu, Apr 2, 2015 at 8:59 AM,
Martin Basti <span dir="ltr"><<a href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div>
<div>
<div>On 30/03/15 15:25, Gabe Alford wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>
<div>Hello,<br>
<br>
</div>
With the merging of ticket <a href="https://fedorahosted.org/freeipa/ticket/4842" target="_blank">4842</a>, I believe that
half of ticket <a href="https://fedorahosted.org/freeipa/ticket/3092" target="_blank">3092</a> has been done.
This patch just adds a message that says
that NTP configuration was skipped which I
believe should finish <a href="https://fedorahosted.org/freeipa/ticket/3092" target="_blank">3092</a>.<br>
<br>
</div>
Thanks,<br>
<br>
</div>
Gabe<br>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
</div>
</div>
Hello, thank you for the patch.<br>
<br>
1)<br>
IMO there should be:<br>
if *not* options.conf_ntp<br>
</div>
</blockquote>
<div><br>
</div>
<div>So, if --no-ntp is not specified, print message that
the client is skipping NTP sync?<br>
</div>
</div>
</div>
</div>
</blockquote></span>
Yes, or did I miss something? I though the message should be shown
only if --no-ntp option is used.<br>
<br>
With your current patch:<br>
<br>
# ipa-client-install --no-ntp<br>
<no ntp related output><br>
<no INFO msg: skipping...><br>
<br>
# ipa-client-install<br>
<output omitted /><br>
Attempting to sync time using ntpd. Will timeout after 15 seconds<br>
Unable to sync time with IPA NTP server, assuming the time is in
sync. Please check that 123 UDP port is opened.<br>
Skipping synchronizing time with IPA NTP server.<br>
<output omitted /><br>
<br>
But in this case the client did synchronization with NTP (which
failed), IMO the message "Skipping ..." should not be there.<br>
This message is shown even the synchronization with NTP is
successful.<span class=""><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> 2)<br>
wouldnt be better to use just else?<span><font color="#888888"><br>
</font></span></div>
</blockquote>
<div><br>
</div>
<div>I actually ran ipa-client-install with no options on a
system where I used 'else', and it printed the skipping
NTP sync when it should not have.<br>
</div>
<div>That is why the patch does not use 'else'.<br>
</div>
</div>
</div>
</div>
</blockquote></span>
Interesting, I expected the messages only on client installed on IPA
server, or with using --no-ntp option<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"><span><font color="#888888"> <br>
Martin<span class="HOEnZb"><font color="#888888"><br>
<pre cols="72">--
Martin Basti</pre>
</font></span></font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
<br>
</font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote><span class="HOEnZb"><font color="#888888">
<br>
<pre cols="72">--
Martin Basti</pre>
</font></span></div>
</blockquote></div><br></div></div>