<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 14/04/15 16:12, Martin Basti wrote:<br>
</div>
<blockquote cite="mid:552D2040.0@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 14/04/15 14:25, Martin Babinsky
wrote:<br>
</div>
<blockquote cite="mid:552D072D.3040002@redhat.com" type="cite">This
patch addresses <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/4966">https://fedorahosted.org/freeipa/ticket/4966</a>
<br>
<br>
The noise during rollback/uninstall is caused mainly by
unsuccessful attempts to remove files that do not exist anymore.
These errors are now logged at debug level and do not pop-up to
stdout/stderr. <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hello, thank you for the patch.<br>
<br>
1)<br>
The option add_warning is quite unclear to me. It does not show
warning but error. I suggest something like, show_hint,
show_user_action, or something show_additional_..., or
promt_manual_removal<br>
<br>
Martin^2<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Continue...<br>
<br>
2)<br>
<br>
if file_exists(preferences_fname):<br>
try:<br>
os.remove(preferences_fname)<br>
except OSError as e:<br>
log_file_removal_error(e, preferences_fname,
True)<br>
<br>
In this case file not found error should never happen.<br>
<br>
Could you remove the 'if file_exists' part and handle just
exception?<br>
<br>
3)<br>
this is inconsistent with change above, choose one style please:<br>
<br>
if os.path.exists(ca_file):<br>
try:<br>
os.unlink(ca_file)<br>
except OSError, e:<br>
root_logger.error(<br>
"Failed to remove '%s': %s", ca_file, e)<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>