<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 17/04/15 16:15, Jan Cholasta wrote:<br>
</div>
<blockquote cite="mid:5531157F.80106@redhat.com" type="cite">Dne
16.4.2015 v 16:46 Jan Cholasta napsal(a):
<br>
<blockquote type="cite">Hi,
<br>
<br>
the attached patch adds the basics of the new installer
framework.
<br>
<br>
As a next step, I plan to convert the install scripts to use the
<br>
framework with their old code (the old code will be gradually
ported to
<br>
the framework later).
<br>
<br>
(Note I didn't manage to write docstrings today, expect update
tomorrow.)
<br>
</blockquote>
<br>
Added some docstrings.
<br>
<br>
Also updated the patch to reflect little brainstorming David and I
had this morning.
<br>
<br>
<blockquote type="cite">
<br>
Honza
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hello, see comments bellow:<br>
<br>
1) We started using new shorter License header in files:<br>
#<br>
# Copyright (C) 2015 FreeIPA Contributors see COPYING for license<br>
#<br>
<br>
2) IMO this will not work, NoneType has no 'obj' attribute<br>
+ else:<br>
+ if isinstance(value, from_):<br>
+ value = None<br>
+ stack.append(value.obj)<br>
+ continue<br>
<br>
3) Multiple inheritance. I do not like it much.<br>
+class CompositeInstaller(Installer, CompositeConfigurator):<br>
<br>
Installer and CompositeConfigurator inherites from Configurator
class, and all of them implements _generator method.<br>
<br>
If I understand correctly
(<a class="moz-txt-link-freetext" href="https://www.python.org/download/releases/2.3/mro/">https://www.python.org/download/releases/2.3/mro/</a>) the
Installer._generator method will be used in this case.<br>
However in case when CompositeConfigurator has more levels
(respectively it is more specialized) of inheritance, it could take
precedence and its _generator method may be used instead.<br>
<br>
I'm afraid this may suddenly stop working.<br>
Maybe I'm wrong, please fix me.<br>
<br>
And Multiple inheritance is not easily readable, this is even a
diamond inheritance model.<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>