<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 28/04/15 15:36, Gabe Alford wrote:<br>
</div>
<blockquote
cite="mid:CAGLxfGzXCCrMsKbCGnSmY3wYJEe4tGCzcMLT=EW2Tm2eOPq3rw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Tue, Apr 28, 2015 at 7:18 AM,
Martin Basti <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div>
<div class="h5">
<div>On 27/04/15 15:02, Gabe Alford wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>
<div>Hello,<br>
<br>
Fix for <a moz-do-not-send="true"
href="https://fedorahosted.org/freeipa/ticket/4575"
target="_blank">https://fedorahosted.org/freeipa/ticket/4575</a><br>
<br>
</div>
Thanks,<br>
<br>
</div>
Gabe</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
</div>
</div>
Hello,<br>
<br>
thank you for your patch, looks good.<br>
<br>
However, IMO you can remove hostaddr variable as well,
it was used for validate IP address.<br>
I could not find it used anywhere, did you?<br>
</div>
</blockquote>
<div><br>
</div>
<div>Removed. It still seemed like it could be a logical
check to have to me which is why I kept it in the first
place.<br>
</div>
<div>Updated patch attached.<br>
</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Martin^2<span
class="HOEnZb"><font color="#888888"><br>
<pre cols="72">--
Martin Basti</pre>
</font></span></div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
Thank you, ACK!<br>
<br>
This check is not needed anymore, it will not work with dualstack,
and adtrustisntance is installed on IPA server which must have
resolvable IP address.<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>