<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 03/06/15 20:40, Drew Erny wrote:<br>
</div>
<blockquote cite="mid:556F4A08.1040202@redhat.com" type="cite">Hi,
all,
<br>
<br>
This is an updated patch, with the code changes suggested by
Martin Batsi in my test email. The biggest difference is that I
had to do
<br>
<br>
>> from ldap import SCOPE_BASE, SCOPE_ONELEVEL,
SCOPE_SUBTREE
<br>
<br>
To get access to those constants in the global scope. This seems
like a fairly clean solution, but if it's a code smell, feel free
to suggest improvements. This should have identical behavior to
the last patch, except it will autofill scope and no longer prompt
interactively.
<br>
<br>
Thanks,
<br>
<br>
Drew Erny
<br>
<a class="moz-txt-link-abbreviated" href="mailto:derny@redhat.com">derny@redhat.com</a>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hello,<br>
<br>
please continue discussion in the same thread :)<br>
<br>
API.txt was changed, please update VERSION file, increment minor
version +1 and edit comment there. I forgot to tell you yesterday.<br>
<br>
Can you rebase your patch to current master?<br>
This patch is supposed to go to IPA 4.2.<br>
<br>
Is the tuple conversion needed?<br>
values=tuple(_supported_scopes.keys()),<br>
<br>
Otherwise patch looks good.<br>
<br>
Martin^2<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>