<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 04/06/15 21:36, Drew Erny wrote: </div> <blockquote cite="mid:5570A8A0.8030600@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> Whoops, hit the wrong "reply". <div class="moz-cite-prefix">On 06/04/2015 03:34 PM, Drew Erny wrote: </div> <blockquote cite="mid:5570A845.7020102@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> This is the same patch sort of manually rebased on the master branch. I couldn't get it to cleanly rebase using tools, so I apply my commit line-by-line; the only changes I made were pulling the "scope = _supported_scopes[options.get('scope')]" out of the for loop I'd accidentally left it in, and moving the import statement to a different spot. Everything else should be the same, excep I incremented VERSION and edited the comment. I do have to convert to tuple, because that argument is expected to be a tuple but .keys() returns a list. </blockquote> </blockquote> Oh right, Enum requires explicitly tuple <blockquote cite="mid:5570A8A0.8030600@redhat.com" type="cite"> <blockquote cite="mid:5570A845.7020102@redhat.com" type="cite"> <div class="moz-cite-prefix">On 06/04/2015 11:35 AM, Martin Basti wrote: </div> <blockquote cite="mid:5570703A.6080709@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 03/06/15 20:40, Drew Erny wrote: </div> <blockquote cite="mid:556F4A08.1040202@redhat.com" type="cite">Hi, all, This is an updated patch, with the code changes suggested by Martin Batsi in my test email. The biggest difference is that I had to do >> from ldap import SCOPE_BASE, SCOPE_ONELEVEL, SCOPE_SUBTREE To get access to those constants in the global scope. This seems like a fairly clean solution, but if it's a code smell, feel free to suggest improvements. This should have identical behavior to the last patch, except it will autofill scope and no longer prompt interactively. Thanks, Drew Erny <a moz-do-not-send="true" class="moz-txt-link-abbreviated" href="mailto:derny@redhat.com">derny@redhat.com</a> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hello, please continue discussion in the same thread :) API.txt was changed, please update VERSION file, increment minor version +1 and edit comment there. I forgot to tell you yesterday. Can you rebase your patch to current master? This patch is supposed to go to IPA 4.2. Is the tuple conversion needed? values=tuple(_supported_scopes.keys()), Otherwise patch looks good. Martin^2 <pre class="moz-signature" cols="72">-- Martin Basti</pre> </blockquote> </blockquote> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Thank you. ACK, it works as expected. Martin^2 <pre class="moz-signature" cols="72">-- Martin Basti</pre> </body> </html>