<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/30/2015 09:19 AM, Ludwig Krispenz
wrote:<br>
</div>
<blockquote cite="mid:5592431D.1020100@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 06/26/2015 02:14 PM, thierry
bordaz wrote:<br>
</div>
<blockquote cite="mid:558D420D.8010603@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/22/2015 11:35 AM, Ludwig
Krispenz wrote:<br>
</div>
<blockquote cite="mid:5587D6FF.8020706@redhat.com" type="cite">fix
for ticket #5065, removing start <br>
- after online init copmpleted <br>
- additionally check after startup <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hi Ludwig,<br>
<br>
The fix looks good to me. <br>
I have just a clarification regarding
ipa_topo_util_reset_init. It resets 'nsds5BeginReplicaRefresh'
at the condition the
segment->[left,right]->target=localhost.<br>
</font></blockquote>
<font face="Times New Roman, Times, serif">it is called
"post_init", after an online initialization, so the host where
this is checked was the target of an init.<br>
at startup, when there is a check, if it is still present, it
will check that it is the origin of a refresh, clear it and not
repeat the init<br>
</font></blockquote>
<br>
<font face="Times New Roman, Times, serif">OK I understand my
mistake now. Thanks for your explanations.<br>
<br>
Would you add a comment that when calling
ipa_topo_util_remove_init_attr (in ipa_topo_util_update_agmt_list)
that it will reset '</font><font face="Times New Roman, Times,
serif">nsds5BeginReplicaRefresh' when the host is a supplier.<br>
Also when calling ipa_topo_util_reset_init (in
ipa_topo_apply_shared_config) that it will reset </font><font
face="Times New Roman, Times, serif">'</font><font face="Times New
Roman, Times, serif">nsds5BeginReplicaRefresh' when the host is a
consumer.<br>
<br>
An other point, ipa_topo_apply_shared_config is called after an
online init of the main suffix. It will reset all </font><font
face="Times New Roman, Times, serif"><font face="Times New Roman,
Times, serif"> </font><font face="Times New Roman, Times,
serif">'</font><font face="Times New Roman, Times, serif">nsds5BeginReplicaRefresh'
(via </font>ipa_topo_apply_shared_replica_config and via
ipa_topo_util_reset_init) on all suffixes. IMHO it is fine because
reinit the shared tree should reset all administrative tasks, but
may be it worth a comment.<br>
<br>
Otherwise the patch is ok for me. <br>
<br>
ACK<br>
<br>
<br>
thanks<br>
thierry<br>
<br>
</font>
<blockquote cite="mid:5592431D.1020100@redhat.com" type="cite"><font
face="Times New Roman, Times, serif"> </font>
<blockquote cite="mid:558D420D.8010603@redhat.com" type="cite"><font
face="Times New Roman, Times, serif"> I would expect it resets
the flag on the master side and so it tests
'segment->[left,right]->origin=localhost'.<br>
<br>
thanks<br>
thierry<br>
</font> </blockquote>
<br>
</blockquote>
<br>
</body>
</html>