<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/30/2015 04:50 PM, Ludwig Krispenz
wrote:<br>
</div>
<blockquote cite="mid:5592AC99.10803@redhat.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
new patch attached<br>
<br>
<div class="moz-cite-prefix">On 06/30/2015 03:37 PM, thierry
bordaz wrote:<br>
</div>
<blockquote cite="mid:55929B9F.2060905@redhat.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/30/2015 12:07 PM, Ludwig
Krispenz wrote:<br>
</div>
<blockquote cite="mid:55926A72.9040205@redhat.com" type="cite">added
verification for issue reported in ticket 5088 and sanity
checks requested in review for patch 0014 <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hello,<br>
<br>
The fix looks good except those sanity settings:<br>
</font>
<ul>
<li><font face="Times New Roman, Times, serif">In
ipa_topo_post_del, tsegm needs to be NULL initialized</font></li>
<li><font face="Times New Roman, Times, serif">In
ipa_topo_check_segment_is_valid or ipa_topo_pre_add, I
think *errtxt should be initialized to NULL </font></li>
</ul>
<p><font face="Times New Roman, Times, serif">thanks<br>
thierry<br>
</font></p>
</blockquote>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">ACK<br>
<br>
thanks<br>
thierry<br>
</font>
</body>
</html>