<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 14/07/15 12:19, Martin Babinsky
wrote:<br>
</div>
<blockquote cite="mid:55A4E229.2090304@redhat.com" type="cite">On
03/30/2015 12:38 PM, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 03/26/2015 01:14 PM, Martin Kosek
wrote:
<br>
<blockquote type="cite">On 03/25/2015 04:18 PM, Jan Cholasta
wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
Dne 25.3.2015 v 15:26 Martin Babinsky napsal(a):
<br>
<blockquote type="cite">The attached patch related to
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4931">https://fedorahosted.org/freeipa/ticket/4931</a>
<br>
</blockquote>
<br>
Please make sure
<a class="moz-txt-link-rfc2396E" href="https://fedorahosted.org/freeipa/ticket/3048"><https://fedorahosted.org/freeipa/ticket/3048></a> stays
<br>
fixed.
<br>
<br>
<blockquote type="cite">
<br>
It is certainly not a final solution, more of an initial
"hack" of
<br>
sorts
<br>
just to gather some suggestions, since I am not even sure
if this is
<br>
the
<br>
right thing to do.
<br>
<br>
The reporter from bugzilla suggests to enable debugging of
ALL commands
<br>
called through ipautil.run(), but I think that fixing all
cca 157 found
<br>
usages of run() is too much work with a quite small
benefit.
<br>
<br>
Anyway I would welcome some opinions about this: should
the external
<br>
commands really inherit the debug settings of ipa-*
utilities, and if
<br>
so, is the method showed in this patch the right way to do
it?
<br>
</blockquote>
<br>
I am not a fan of this method, ipautil.run does not know
anything
<br>
about the
<br>
command it runs and I think it should stay that way.
<br>
<br>
I would prefer to have an ipautil.run wrapper with debug
flag using
<br>
appropriate
<br>
debugging option for each command where we need to
conditionally enable
<br>
debugging. Or just add the debugging option unconditionally
to every
<br>
command
<br>
where it could be useful.
<br>
</blockquote>
<br>
+1, I do not like this change to ipautil.run either. It should
be sole
<br>
responsibility of the caller to specify the right combinations
of
<br>
options,
<br>
including debug option, where applicable.
<br>
<br>
</blockquote>
Attaching updated patch.
<br>
<br>
<br>
<br>
</blockquote>
Reviving this patch from the dead. Attaching rebased version for
master branch and ipa-4-1.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Works for me, ACK<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>