<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 24/07/15 05:15, Fraser Tweedale
wrote:<br>
</div>
<blockquote
cite="mid:20150724031528.GG20599@dhcp-40-8.bne.redhat.com"
type="cite">
<blockquote type="cite">
<pre wrap="">diff --git a/ipalib/plugins/certprofile.py b/ipalib/plugins/certprofile.py
index 5550ed942521dbab2e783fba1570520268f9b378..fe8934690fe09499f0bacb6610d9815a2b4367a4 100644
--- a/ipalib/plugins/certprofile.py
+++ b/ipalib/plugins/certprofile.py
@@ -233,8 +233,8 @@ class certprofile_import(LDAPCreate):
match = self.PROFILE_ID_PATTERN.search(options['file'])
if match is None:
- raise errors.ValidationError(name='file',
- error=_("Profile ID is not present in profile data"))
+ # no profileId found, use CLI value as profileId.
+ options['file'] = u'profileId=%s\n%s' % (keys[0], options['file'])
</pre>
</blockquote>
<pre wrap="">
NACK
This assignment has no external effect; `post_callback' is called
with original `options['file']' and dogtag profile import can fail
due to missing profileId.
The solution is to do the same thing in post_callback; updated patch
attached.
Thanks,
Fraser
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
I dont like to have the same code twice in pre and post callback.<br>
<br>
Can you use contexmanager to store the right value in pre callback
and then use it in post callback?<br>
(can find it in dns plugin, search for context)<br>
<br>
Martin^2<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>