<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 29/07/15 15:29, Lenka Doudova wrote:<br>
</div>
<blockquote cite="mid:55B8D552.8040306@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Hi,<br>
<br>
thanks a lot for the comments, will work on it tomorrow.<br>
<br>
Lenka<br>
<br>
<div class="moz-cite-prefix">Dne 29.7.2015 v 15:27 Martin Basti
napsal(a):<br>
</div>
<blockquote cite="mid:55B8D4B4.8090303@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 27/07/15 16:47, Lenka Doudova
wrote:<br>
</div>
<blockquote cite="mid:55B64495.30309@redhat.com" type="cite">Hi,
<br>
<br>
I'm attaching a patch with automated tests for stageuser
plugin (<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/3813">https://fedorahosted.org/freeipa/ticket/3813</a>).
The user plugin test is affected as well (one class was
added). <br>
The tests seem a bit of a mess even to myself, but what with
the way freeipa behaves I didn't know how else to implement
them, but I'm eager to learn how to do it in a nicer way, if
someone has a better idea. <br>
<br>
Lenka <br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
I just applied patches:<br>
<br>
1) Please remove whitespace errors<br>
$ git am
freeipa-lryznaro-0002-Automated-test-for-stageuser-plugin.patch<br>
Applying: Automated test for stageuser plugin<br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:110:
trailing whitespace.<br>
""" Tracker class for staged user LDAP object <br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:113:
trailing whitespace.<br>
StageUserTracker object stores information about the
user. <br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:121:
trailing whitespace.<br>
u'krbprincipalexpiration', u'usercertificate', u'dn',
u'has_keytab', u'has_password', <br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:122:
trailing whitespace.<br>
u'street', u'postalcode', u'facsimiletelephonenumber',
u'carlicense', <br>
/home/mbasti/work/freeipa-devel/.git/rebase-apply/patch:125:
trailing whitespace.<br>
u'cn', u'ipauniqueid', u'objectclass', u'description', <br>
warning: squelched 50 whitespace errors<br>
warning: 55 lines add whitespace errors.<br>
<br>
2)<br>
Please use new shorter format of license header<br>
<br>
3) can you fix some of the most serious PEP8 errors<br>
$ git show -U0 | pep8 --diff | wc -l<br>
198<br>
<br>
4)<br>
if options != None:<br>
<br>
Please use "options *is not* None"<br>
<br>
5) <br>
For consistency it should be u'random'<br>
if key == 'random':<br>
self.attrs[u'randompassword'] = fuzzy_string<br>
<br>
Otherwise it looks good<br>
Martin^2<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</blockquote>
<br>
</blockquote>
And also fix this please<br>
<br>
./make-lint <br>
************* Module ipatests.test_xmlrpc.test_stageuser_plugin<br>
ipatests/test_xmlrpc/test_stageuser_plugin.py:337:
[E0102(function-redefined), user2] function already defined line 44)<br>
<br>
<pre class="moz-signature" cols="72">--
Martin Basti</pre>
</body>
</html>