<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 08/10/2015 06:02 PM, Milan Kubík
wrote:<br>
</div>
<blockquote cite="mid:55C8CB13.7080201@redhat.com" type="cite">On
08/10/2015 05:54 PM, Jan Cholasta wrote:
<br>
<blockquote type="cite">On 10.8.2015 17:43, Milan Kubík wrote:
<br>
<blockquote type="cite">Hi all,
<br>
<br>
this patch fixes problem described in the ticket [1]
<br>
that caused the test run to fail completely at every other or
so run.
<br>
I took the liberty to fix most of the pep8 issues while I was
at it.
<br>
<br>
Thanks to Jan Cholasta for help with identifying this one.
<br>
</blockquote>
<br>
IMO this would be more robust:
<br>
<br>
t = None
<br>
try:
<br>
...
<br>
finally:
<br>
del t
<br>
nss.nss_shutdown()
<br>
<br>
By assigning a value to the variable at the beginning you make
sure that the del statement will not fail.
<br>
<br>
Honza
<br>
<br>
</blockquote>
Thanks for the idea. It also removed the version check.
<br>
Updated patch attached.
<br>
<br>
Milan
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Self NACK.<br>
<br>
I have updated the fix for all of the leaks in that class. It seems
to corrupt the database even when no init/shutdown was called. Just
not so often.<br>
<br>
Milan<br>
</body>
</html>