<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 09/02/2015 03:16 PM, Jan Cholasta
wrote:<br>
</div>
<blockquote cite="mid:55E6F6A3.6060400@redhat.com" type="cite">On
2.9.2015 14:51, Martin Basti wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 09/02/2015 02:32 PM, Jan Cholasta wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
the attached patch fixes
<a class="moz-txt-link-rfc2396E" href="https://fedorahosted.org/freeipa/ticket/5268"><https://fedorahosted.org/freeipa/ticket/5268></a>.
<br>
<br>
Honza
<br>
<br>
<br>
<br>
</blockquote>
<br>
This patch needs a big rebase to ipa-4-2 branch
<br>
</blockquote>
<br>
Patch attached.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hello,<br>
<br>
Two minors questions. LDAPClient close/__del__/__exit__ are now
just resetting self._conn without disconnecting the connection.<br>
Only ldap2.close() disconnect the connection. Could it be a risk
to see connection leaks with __del__ or __exit__ ?<br>
<br>
Also in the fix there is:</font><br>
<pre wrap="">@@ -118,10 +115,11 @@ class ldap2(CrudBackend, LDAPClient):
if debug_level:
_ldap.set_option(_ldap.OPT_DEBUG_LEVEL, debug_level)
- LDAPClient._connect(self)
- conn = self._conn
+ client = LDAPClient(self.ldap_uri,
+ force_schema_updates=self._force_schema_updates)
+ conn = client._conn
Is it the same as 'conn = client.conn()' ?
Thanks
thierry
</pre>
</body>
</html>