<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 09/23/2015 05:01 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:5602BECD.8070705@redhat.com" type="cite">
<br>
<br>
On 09/22/2015 12:10 PM, Jan Cholasta wrote:
<br>
<blockquote type="cite">On 22.9.2015 10:29, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 09/16/2015 10:44 AM, Jan Cholasta
wrote:
<br>
<blockquote type="cite">On 16.9.2015 08:11, Jan Cholasta
wrote:
<br>
<blockquote type="cite">On 15.9.2015 07:22, Jan Cholasta
wrote:
<br>
<blockquote type="cite">On 10.8.2015 16:58, Martin
Babinsky wrote:
<br>
<blockquote type="cite">On 08/06/2015 08:22 AM, Jan
Cholasta wrote:
<br>
<blockquote type="cite">Hi,
<br>
<br>
the attached patch fixes part of
<br>
<a class="moz-txt-link-rfc2396E" href="https://fedorahosted.org/freeipa/ticket/4517"><https://fedorahosted.org/freeipa/ticket/4517></a>.
<br>
<br>
See also Martin Babinsky's patch 51:
<br>
<a class="moz-txt-link-rfc2396E" href="https://www.redhat.com/archives/freeipa-devel/2015-August/msg00012.html"><https://www.redhat.com/archives/freeipa-devel/2015-August/msg00012.html></a>.
<br>
<br>
<br>
<br>
<br>
<br>
<br>
Honza
<br>
<br>
</blockquote>
<br>
Sorry but NACK, see below:
<br>
<br>
1.) it seems that passing kwargs to Server components
doesn't work as
<br>
expected. See these logs (install on fresh F22 VM):
<br>
<br>
<a class="moz-txt-link-freetext" href="http://fpaste.org/253416/21363814/">http://fpaste.org/253416/21363814/</a>
<br>
<a class="moz-txt-link-freetext" href="http://fpaste.org/253419/43921374/">http://fpaste.org/253419/43921374/</a>
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
<blockquote type="cite">
<br>
2.) the following code blows up in BaseServers'
__init__:
<br>
(<a class="moz-txt-link-freetext" href="http://fpaste.org/253400/21225314/">http://fpaste.org/253400/21225314/</a>)
<br>
<br>
392 if not self.dns.setup_dns:
<br>
393 if self.dns.forwarders:
<br>
394 raise RuntimeError(
<br>
395 "You cannot specify a
--forwarder option
<br>
without
<br>
the "
<br>
396 "--setup-dns option")
<br>
<br>
<br>
I think that the check should be:
<br>
<br>
392 if not self.setup_dns:
<br>
393 if self.dns.forwarders:
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
<blockquote type="cite">
<br>
IMHO BaseServerDNS class shouldn't have setup_dns
knob, that should be
<br>
set in the parent class (BaseServer)
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
<blockquote type="cite">
<br>
3.) Is there any reason why BaseServer doesn't have
'master_password',
<br>
'idmax' and 'idstart' knobs? I know that these are
then brought in by
<br>
the derived Server class, but the check for them is in
parent's
<br>
__init__() method and it is IMHO a bit confusing
<br>
</blockquote>
<br>
The check should be in Server, fixed.
<br>
<br>
<blockquote type="cite">
<br>
4.) please add license header to the beginning of
<br>
'ipaserver/install/server/common.py' file
<br>
</blockquote>
<br>
Added.
<br>
<br>
Updated patches attached.
<br>
</blockquote>
<br>
Self-NACK, I broke ipa-server-install --uninstall.
<br>
</blockquote>
<br>
Fixed.
<br>
<br>
</blockquote>
<br>
ACK to all three patches.
<br>
<br>
</blockquote>
<br>
Thanks.
<br>
<br>
Pushed to:
<br>
master: 86edd6abeb9749e159a529b83cfce6443fff4ba5
<br>
ipa-4-2: 42d16b02cd153ac89ebd8ae07c98611dc3b6e471
<br>
<br>
</blockquote>
These patches introduced regression.
<br>
ipa-replica-install in unattended mode requires to specify -a, -p
and -r options.
<br>
<br>
Attached patch fixes it.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Works for me, ACK.<br>
<br>
Milan<br>
</body>
</html>