<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 10/02/2015 04:14 PM, Milan Kubík
wrote:<br>
</div>
<blockquote cite="mid:560E913A.7030009@redhat.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">On 10/02/2015 04:11 PM, Martin Basti
wrote:<br>
</div>
<blockquote cite="mid:560E90AA.3080108@redhat.com" type="cite"> <br>
<br>
On 10/01/2015 02:48 PM, Martin Basti wrote: <br>
<blockquote type="cite"> <br>
<br>
On 10/01/2015 02:43 PM, Oleg Fayans wrote: <br>
<blockquote type="cite">Hi Martin, <br>
<br>
On 10/01/2015 11:18 AM, Martin Basti wrote: <br>
<blockquote type="cite"> <br>
<br>
On 09/30/2015 01:24 PM, Martin Basti wrote: <br>
<blockquote type="cite"> <br>
<br>
On 09/30/2015 12:19 PM, Oleg Fayans wrote: <br>
<blockquote type="cite"> <br>
<br>
On 09/30/2015 11:46 AM, Petr Spacek wrote: <br>
<blockquote type="cite">On 29.9.2015 09:12, Oleg
Fayans wrote: <br>
<blockquote type="cite">+def
prepare_reverse_zone(host, ip): <br>
+ zone = get_reverse_zone_default(ip) <br>
+ host.run_command(["ipa", <br>
+ "dnszone-add", <br>
+ zone, <br>
+ "--name-from-ip=%s" % ip],
raiseonerr=False) <br>
</blockquote>
<br>
There is probably no point in specifying
--name-from-ip because you <br>
did that <br>
already by calling get_reverse_zone_default(ip). <br>
</blockquote>
<br>
Agree. Fixed <br>
<br>
<blockquote type="cite"> <br>
Anyway, I'm not sure that this <br>
<blockquote type="cite">+
prepare_reverse_zone(master, replica.ip) <br>
</blockquote>
will not break if the reverse zone already exists
(think about case <br>
where two <br>
or more replicas are in the same subnet). <br>
</blockquote>
<br>
That's why I am using the raiseonerr=False here. <br>
<br>
<blockquote type="cite"> <br>
I did not test the code, I simply do not have time
for it right now. <br>
<br>
</blockquote>
<br>
<br>
<br>
</blockquote>
LGTM, I will test it soon, but it needs rebase for
ipa-4-2 branch <br>
<br>
<br>
</blockquote>
ACK, please send rebased version for ipa-4-2 <br>
</blockquote>
<br>
Here it is <br>
<br>
</blockquote>
Pushed to ipa-4-2: c898c968d3979a0d8c2fe0db8e125dfc2268eba0 <br>
Pushed to master: 03d696f224642c1c4c4f1a434fecefd1c6270e37 <br>
<br>
</blockquote>
<br>
In rebased patch for ipa-4-2 you removed import for function and
I didn't noticed that. <br>
This breaks builds of ipa-4-2. <br>
<br>
Patch that fix this attached. <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
ACK<br>
<br>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
</blockquote>
Pushed to ipa-4-2: e7a33b71256dbda37308c4fd0ac5394472c753f7<br>
</body>
</html>