<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Ludwig,<br>
<br>
Thanks for the patch.<br>
Yes it is looking good to me. Just a minor change about the
message logged (if case of failure to add the cleanallruv task),
you may recommend to the administrator the exact command to run.<br>
<br>
ACK<br>
<br>
thanks<br>
thierry<br>
On 10/23/2015 02:27 PM, Ludwig Krispenz wrote:<br>
</div>
<blockquote cite="mid:562A27CC.1070402@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
Hi Thierry,<br>
<br>
hope this addresses your concerns<br>
<br>
Ludwig<br>
<br>
<div class="moz-cite-prefix">On 10/23/2015 11:24 AM, thierry
bordaz wrote:<br>
</div>
<blockquote cite="mid:5629FCE7.9070709@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 10/23/2015 11:00 AM, thierry
bordaz wrote:<br>
</div>
<blockquote cite="mid:5629F72D.9020807@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 10/12/2015 01:17 PM, Ludwig
Krispenz wrote:<br>
</div>
<blockquote cite="mid:561B96CE.9060404@redhat.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 10/12/2015 12:44 PM, Martin
Basti wrote:<br>
</div>
<blockquote cite="mid:561B8F0B.4070907@redhat.com"
type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 23.07.2015 10:46, Ludwig
Krispenz wrote:<br>
</div>
<blockquote cite="mid:55B0A9F0.4010602@redhat.com"
type="cite">The attached patch moves the cleaning of the
RUV into the topology plugin. <br>
<br>
I encountered a problem when removing a replica, which
disconnects the topology, but it was fixed with my WIP
for #5072. <br>
<br>
I want to keep these issues separate, so please review
and test the patch and let me know about issues found <br>
<br>
Ludwig <br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Is this patch still valid and pending review?<br>
</blockquote>
it should be still valid, waiting for review, wanted to
rebase after topology/promotion patches have been checked in
and resend<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hello Ludwig,<br>
<br>
The patch looks good. I have few minor remarks:</font><br>
<ul>
<li><font face="Times New Roman, Times, serif">Are the
hostname in ruv always fqdn ? to retrieve the RUV
element of a given host you use 'strstr'.<br>
If you have host vm-11 and vm-112, I wonder if it could
pickup the wrong RUV element</font></li>
<li><font face="Times New Roman, Times, serif">In
ipa_topo_util_cleanruv_element you need a
pblock_done/free (or destroy)<br>
</font></li>
<li><font face="Times New Roman, Times, serif">In it fails
to add the clearn-ruv task, you should log a message so
that the admin knows what to do.</font></li>
</ul>
<p><font face="Times New Roman, Times, serif">thanks<br>
thierry<br>
</font></p>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hi Ludwig,<br>
<br>
Additional question. cleanruv is done with
'replica-force-cleaning: yes'. Currently ipa-replica-manage
does not implement this flag.<br>
Why do you use it in topology plugin.<br>
My concern is that if we delete a host before all the updates
from that host has been received, could we receive a late
update that will recreate the ruv element ?<br>
<br>
thanks<br>
thierry<br>
</font> </blockquote>
<br>
</blockquote>
<br>
</body>
</html>