<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 10/23/2015 10:44 AM, Ludwig Krispenz
wrote:<br>
</div>
<blockquote cite="mid:5629F352.9050005@redhat.com" type="cite">Hi,
<br>
the attached two patches address issues I found when testing ca
management in the topology plugin
<br>
<br>
Thanks for review,
<br>
Ludwig
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<font face="Times New Roman, Times, serif">Hi Ludwig,<br>
<br>
Patch 20 is good to me. I have one remark, you call
ipa_topo_cfg_host_find with lock flag. So that the replica config
is not updated during the test.<br>
Now the lock protects each call separately. The risk is very low
that the target host could become unmanaged by the time we test
the source host.<br>
ACK.<br>
<br>
Patch 21 is also good. Just </font><font face="Times New Roman,
Times, serif">in ipa_topo_util_init_hosts, why not calling
ipa_topo_cfg_host_add to not duplicate the source ?</font><br>
<br>
<font face="Times New Roman, Times, serif">thanks<br>
thierry<br>
</font>
</body>
</html>