<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 11/27/2015 03:31 PM, Milan Kubík
wrote:<br>
</div>
<blockquote cite="mid:5658694F.3080404@redhat.com" type="cite">On
11/23/2015 10:43 AM, Lenka Doudova wrote:
<br>
<blockquote type="cite">NACK - there's a "typo" in
..../tracker/user_plugin.py, line 17-18:
<br>
<br>
def get_user_dn(cn):
<br>
<br>
return DN(('cn', cn), api.env.container_user,
api.env.basedn)
<br>
<br>
<br>
should be
<br>
<br>
def get_user_dn(uid):
<br>
<br>
return DN(('uid', uid), api.env.container_user,
api.env.basedn)
<br>
<br>
<br>
Some tests may fail because of that.
<br>
Lenka
<br>
<br>
<br>
On 11/20/2015 08:54 PM, Aleš Mareček wrote:
<br>
<blockquote type="cite">Looks good. ACK.
<br>
<br>
----- Original Message -----
<br>
<blockquote type="cite">From: "Milan Kubík"
<a class="moz-txt-link-rfc2396E" href="mailto:mkubik@redhat.com"><mkubik@redhat.com></a>
<br>
To: "freeipa-devel" <a class="moz-txt-link-rfc2396E" href="mailto:freeipa-devel@redhat.com"><freeipa-devel@redhat.com></a>
<br>
Cc: "Filip Skola" <a class="moz-txt-link-rfc2396E" href="mailto:fskola@redhat.com"><fskola@redhat.com></a>, "Ales Marecek"
<a class="moz-txt-link-rfc2396E" href="mailto:amarecek@redhat.com"><amarecek@redhat.com></a>
<br>
Sent: Friday, November 20, 2015 3:44:30 PM
<br>
Subject: [patch 0025] Separated Tracker implementations into
standalone package
<br>
<br>
Fixes <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5467">https://fedorahosted.org/freeipa/ticket/5467</a>
<br>
Patches attached.
<br>
<br>
-- <br>
Milan Kubik
<br>
<br>
<br>
</blockquote>
</blockquote>
<br>
</blockquote>
Fixed the function and moved it into different module.
<br>
Updated patches attached.
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Self nack, some imports missing<br>
<br>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
</body>
</html>