<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
ACK<br>
<br>
Pushed to master: 12e7f71600e62eab9d48a13fba37d2f182c8bdee<br>
<br>
<div class="moz-cite-prefix">On 09.12.2015 14:44, Gabe Alford wrote:<br>
</div>
<blockquote
cite="mid:CAGLxfGwAvgF01+shiy=2A69TXxYFuKbCUaq5X4a2vnpQLXR6JQ@mail.gmail.com"
type="cite">
<div dir="ltr">Fixed. Updated patch attached.<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Dec 9, 2015 at 2:37 AM, Martin
Basti <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">NACK<br>
<br>
Patch contains syntax error, missing brace<br>
<br>
ipaserver/install/server/replicainstall.py:850:
[E0001(syntax-error), ] invalid syntax)<span class="HOEnZb"><font
color="#888888"><br>
<br>
Martin</font></span>
<div class="HOEnZb">
<div class="h5"><br>
<br>
On 09.12.2015 07:08, Jan Cholasta wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
LGTM<br>
<br>
On 8.12.2015 17:04, Gabe Alford wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Updated patch attached.<br>
<br>
On Tue, Dec 8, 2015 at 8:27 AM, Martin Basti <<a
moz-do-not-send="true"
href="mailto:mbasti@redhat.com" target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:mbasti@redhat.com">mbasti@redhat.com</a></a><br>
<mailto:<a moz-do-not-send="true"
href="mailto:mbasti@redhat.com" target="_blank">mbasti@redhat.com</a>>>
wrote:<br>
<br>
<br>
<br>
On 08.12.2015 16:26, Gabe Alford wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
Just to confirm:<br>
<br>
if server is installed:<br>
Let's stop here and not do anything else<br>
<br>
if domain level 0:<br>
check if client installed and stop here<br>
<br>
Right?<br>
</blockquote>
yes<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Tue, Dec 8, 2015 at 8:20 AM, Jan Cholasta
<<a moz-do-not-send="true"
href="mailto:jcholast@redhat.com"
target="_blank">jcholast@redhat.com</a><br>
<mailto:<a moz-do-not-send="true"
href="mailto:jcholast@redhat.com"
target="_blank">jcholast@redhat.com</a>>>
wrote:<br>
<br>
On 8.12.2015 16:17, Martin Basti wrote:<br>
<br>
<br>
<br>
On 08.12.2015 16:14, Jan Cholasta
wrote:<br>
<br>
On 8.12.2015 16:09, Martin Basti
wrote:<br>
<br>
<br>
<br>
On 01.12.2015 14:57, Gabe
Alford wrote:<br>
<br>
Sorry guys, I forgot to
add a meaningful<br>
subject to this message.<br>
Ignore the previous thread
start.<br>
<br>
---------- Forwarded
message ----------<br>
From: *Gabe Alford* <<a
moz-do-not-send="true"
href="mailto:redhatrises@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:redhatrises@gmail.com">redhatrises@gmail.com</a></a><br>
<mailto:<a
moz-do-not-send="true"
href="mailto:redhatrises@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:redhatrises@gmail.com">redhatrises@gmail.com</a></a>><br>
<mailto:<a
moz-do-not-send="true"
href="mailto:redhatrises@gmail.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:redhatrises@gmail.com">redhatrises@gmail.com</a></a><br>
<mailto:<a moz-do-not-send="true"
href="mailto:redhatrises@gmail.com"
target="_blank">redhatrises@gmail.com</a>>>><br>
Date: Mon, Nov 30, 2015 at
7:31 PM<br>
Subject: [PATCH 0065]<br>
To: freeipa-devel <<a
moz-do-not-send="true"
href="mailto:freeipa-devel@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a></a><br>
<mailto:<a moz-do-not-send="true"
href="mailto:freeipa-devel@redhat.com"
target="_blank">freeipa-devel@redhat.com</a>><br>
<mailto:<a
moz-do-not-send="true"
href="mailto:freeipa-devel@redhat.com"
target="_blank"><a class="moz-txt-link-abbreviated" href="mailto:freeipa-devel@redhat.com">freeipa-devel@redhat.com</a></a><br>
<mailto:<a moz-do-not-send="true"
href="mailto:freeipa-devel@redhat.com"
target="_blank">freeipa-devel@redhat.com</a>>>><br>
<br>
<br>
Hello,<br>
<br>
Patch fix for the
following tickets:<br>
<br>
<a moz-do-not-send="true"
href="https://fedorahosted.org/freeipa/ticket/5022"
rel="noreferrer" target="_blank">https://fedorahosted.org/freeipa/ticket/5022</a><br>
<a moz-do-not-send="true"
href="https://fedorahosted.org/freeipa/ticket/5320"
rel="noreferrer" target="_blank">https://fedorahosted.org/freeipa/ticket/5320</a><br>
<br>
Thanks,<br>
<br>
Gabe<br>
<br>
<br>
<br>
ACK<br>
<br>
<br>
NACK, you can't install a server
over an already<br>
installed client,<br>
thus the original check is
correct.<br>
<br>
Ahh domain level 0, right, but this
check can be added<br>
before the client<br>
check.<br>
<br>
<br>
Yes.<br>
<br>
With domain level 1, this check should
stay there IMO.<br>
<br>
<br>
Yes. It should say "IPA server is already
configured" rather<br>
than "IPA replica is already configured",
though.<br>
<br>
--<br>
Jan Cholasta<br>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>