<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<br>
<div class="moz-cite-prefix">On 21.03.2016 16:51, Petr Spacek wrote:<br>
</div>
<blockquote cite="mid:56F01891.5030704@redhat.com" type="cite">
<pre wrap="">On 10.3.2016 22:17, Lukas Slebodnik wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On (10/03/16 22:14), Petr Spacek wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hello,
I forgot to send a patches before I leave, so here it is:
Auto-detect default value for --forward-policy option in installers
See
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5710">https://fedorahosted.org/freeipa/ticket/5710</a>
commit messages, and design page
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones">https://fedorahosted.org/bind-dyndb-ldap/wiki/BIND9/Design/AutomaticEmptyZones</a>
I did not have time to test it thoroughly but it LGTM :-D
Please note that this is first part, it does not solve upgrade (yet) and
warnings in forwardzone-* interface.
This can be solved in another patch set, this can be pushed if it passes review.
</pre>
</blockquote>
<pre wrap="">ENOPATH
</pre>
</blockquote>
<pre wrap="">
LOL, here it is.
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
* Remove function ipapython.ipautil.host_exists() *<br>
ACK<br>
<br>
<br>
* Extend installers with --forward-policy option *<br>
1)<br>
There is no --forward-policy option in ipa-dns-install<br>
<br>
<br>
* Move automatic empty zone list into ipapython.dnsutil and make it
reusable *<br>
ACK<br>
<br>
<br>
* Add assert_absolute_dnsname() helper to ipapython.dnsutil *<br>
ACK<br>
<br>
<br>
* Move function is_auto_empty_zone() into ipapython.dnsutil *<br>
ACK<br>
<br>
<br>
* Use shared sanity check and tests
ipapython.dnsutil.is_auto_empty_zone() *<br>
ACK<br>
<br>
* Add function ipapython.dnsutil.inside_auto_empty_zone() *<br>
ACK<br>
<br>
* Auto-detect default value for --forward-policy option in
installers *<br>
LGTM, but ipa-dns-install is missing option --forward-policy<br>
<br>
# ipa-dns-install <br>
...<br>
Unexpected error - see /var/log/ipaserver-install.log for details:<br>
AttributeError: Values instance has no attribute 'forward_policy'<br>
<br>
<br>
Summary: 6 ACKs, 1 LGTM, 1 NACK => NACK<br>
<br>
Martin^2<br>
</body>
</html>