<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 04/21/2016 03:29 PM, Martin Babinsky
wrote:<br>
</div>
<blockquote cite="mid:5718D5CB.200@redhat.com" type="cite">On
04/21/2016 03:25 PM, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 04/21/2016 11:24 AM, Milan Kubík wrote:
<br>
<blockquote type="cite">On 04/05/2016 12:07 PM, Martin Babinsky
wrote:
<br>
<blockquote type="cite">On 04/05/2016 10:24 AM, Milan Kubík
wrote:
<br>
<blockquote type="cite">On 04/05/2016 10:17 AM, Milan Kubík
wrote:
<br>
<blockquote type="cite">On 04/05/2016 09:31 AM, Martin
Babinsky wrote:
<br>
<blockquote type="cite">On 04/01/2016 12:02 PM, Milan
Kubík wrote:
<br>
<br>
<blockquote type="cite">Patches attached.
<br>
<br>
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5733">https://fedorahosted.org/freeipa/ticket/5733</a>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
</blockquote>
Hi Milan,
<br>
<br>
<br>
<br>
I would be more happy if you could send a separate
patch for the
<br>
context
<br>
manager fix, since the issue is orthogonal to the
added test case
<br>
(even
<br>
if the test suite explodes without it).
<br>
<br>
<br>
<br>
Otherwise LGTM.
<br>
<br>
<br>
<br>
<br>
<br>
</blockquote>
<br>
Done. Patch 0035 now applies to all branches, context
manager fix
<br>
needs separate patch for ipa-4-2.
<br>
<br>
</blockquote>
Updated commit message in patches 0036 to include the
ticket.
<br>
<br>
</blockquote>
Thanks, ACK.
<br>
<br>
</blockquote>
Add freeipa-devel back to the loop & push request :)
<br>
<br>
--
<br>
Milan Kubik
<br>
<br>
</blockquote>
Ah sorry I forgot how to mailing list.
<br>
<br>
ACK again for our push-bot (aka mbasti)
<br>
<br>
</blockquote>
<br>
I see that the fix for the failing test was already pushed so you
can remove the xfail mark from the test and it should be all green
now.
<br>
<br>
Sorry for the confusion.
<br>
<br>
</blockquote>
<br>
I haven't noticed, sorry. Updated patch attached.<br>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Milan Kubik</pre>
</body>
</html>