<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 28.04.2016 16:09, Martin Basti wrote: </div> <blockquote cite="mid:5722198D.2040305@redhat.com" type="cite"> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> <div class="moz-cite-prefix">On 08.04.2016 10:32, Peter Lacko wrote: </div> <blockquote cite="mid:2130310256.43083012.1460104345665.JavaMail.zimbra@redhat.com" type="cite"> <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Hello, I have a few comments: 1) Please set up your git name and email correctly (consistently for all patches) <pre wrap="">this is not right From: root <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:root@vm-058-184.abc.idm.lab.eng.brq.redhat.com"><root@vm-058-184.abc.idm.lab.eng.brq.redhat.com></a> 2) -# Copyright (C) 2012 Red Hat +# Copyright (C) 2016 Red Hat leave there both years please +# Copyright (C) 2012, 2016 Red Hat 3) Please put the patch number to the email subject, it is easier to find correct patch for us Otherwise LGTM and works for me. </pre> Martin^2 <fieldset class="mimeAttachmentHeader"></fieldset> </blockquote> Sorry I didn't noticed earlier, but your patch doesn't work under python3 from xmlrpc_test import XMLRPC_test, raises_exact E ImportError: No module named 'xmlrpc_test' You must use absolute import, not relative in py3 Martin^2 </body> </html>