<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 10.05.2016 13:59, Abhijeet Kasurde
wrote:<br>
</div>
<blockquote cite="mid:5731CD3D.9090306@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
Hi All,<br>
<br>
Please find the patch for review.<br>
<br>
Thanks,<br>
Abhijeet Kasurde<br>
<br>
<div class="moz-cite-prefix">On 05/10/2016 01:13 PM, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:8524648f-ff10-6747-07d3-b1ca6bafb13d@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 09.05.2016 07:26, Abhijeet
Kasurde wrote:<br>
</div>
<blockquote cite="mid:57301F9B.6070005@redhat.com" type="cite">Hi
all, <br>
<br>
Please review the patch. <br>
<br>
Fixes: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugzilla.redhat.com/show_bug.cgi?id=1333755">https://bugzilla.redhat.com/show_bug.cgi?id=1333755</a>
<br>
<br>
Thanks, <br>
Abhijeet Kasurde <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Hello,<br>
<br>
<pre wrap="">+ self.raise_certificate_operation_error('parse',
+ detail=e.msg)
Please use detail=str(e), e.msg is deprecated
Martin^2
</pre>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
For future:<br>
* patches should contain trac ticket instead of a BZ link (I amended
patch with ticket)<br>
* BZ was marked as wontfix, but because patch was trivial I reopened
BZ and cloned ticket to trac. Please don't do any wontfix
tickets/bz, any patches for these will be rejected<br>
<br>
ACK<br>
<br>
master:<br>
* 2df25cb359723dd72077c60a12bc037d5c77f931 Added exception handling
for mal-formatted XML Parsing<br>
<br>
</body>
</html>