<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>NACK, see my comments below<br>
</p>
<pre wrap="">+ # following upgrade steps require running CA
</pre>
This is a nitpicky nitpick but could you please change this comment
for # the following ...<br>
Took me a while to understand what you were trying to say here.<br>
<pre wrap="">+ if ca_running and not ca.is_running():
+ ca.stop('pki-tomcat')
+ elif not ca_running and ca.is_running():
+ ca.start('pki-tomcat')
+</pre>
You should swap ca.stop and ca.start here, you're stopping the
service when it's stopped and starting it when it's already running.<br>
<br>
<div class="moz-cite-prefix">On 05/12/2016 04:34 PM, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:cabf4654-b368-b4b8-d936-7a3f2056d25a@redhat.com"
type="cite">Patch attached.
<br>
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5868">https://fedorahosted.org/freeipa/ticket/5868</a>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>