<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 05/20/2016 03:00 PM, Martin Basti wrote:<br>
<blockquote
cite="mid:b870619f-5106-c9be-fd23-c2c911cb9aa0@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<div class="moz-cite-prefix">On 19.05.2016 13:34, Stanislav
Laznicka wrote:<br>
</div>
<blockquote
cite="mid:a24884c3-64af-797c-1a20-558638cabf11@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p>Also, I tried to upgrade from 4.2.4 to 4.3.1 and it seems
that it might be necessary to start the service even earlier
in the upgrade logic. Attached is the trace that occurred
during the upgrade.<br>
</p>
<div class="moz-forward-container">I sent the whole log earlier
accidentally, hopefully it will not arrive here as well.</div>
<br>
<div class="moz-cite-prefix">On 05/19/2016 11:10 AM, Stanislav
Laznicka wrote:<br>
</div>
<blockquote
cite="mid:a19f25d0-f244-1b76-62f3-3b58d7a1ad7a@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p>NACK, see my comments below<br>
</p>
<pre wrap="">+ # following upgrade steps require running CA
</pre>
This is a nitpicky nitpick but could you please change this
comment for # the following ...<br>
Took me a while to understand what you were trying to say
here.<br>
<pre wrap="">+ if ca_running and not ca.is_running():
+ ca.stop('pki-tomcat')
+ elif not ca_running and ca.is_running():
+ ca.start('pki-tomcat')
+</pre>
You should swap ca.stop and ca.start here, you're stopping the
service when it's stopped and starting it when it's already
running.<br>
</blockquote>
</blockquote>
Shame, shame, shame on me.<br>
<br>
<blockquote
cite="mid:a24884c3-64af-797c-1a20-558638cabf11@redhat.com"
type="cite">
<blockquote
cite="mid:a19f25d0-f244-1b76-62f3-3b58d7a1ad7a@redhat.com"
type="cite"> <br>
<div class="moz-cite-prefix">On 05/12/2016 04:34 PM, Martin
Basti wrote:<br>
</div>
<blockquote
cite="mid:cabf4654-b368-b4b8-d936-7a3f2056d25a@redhat.com"
type="cite">Patch attached. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5868">https://fedorahosted.org/freeipa/ticket/5868</a>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</blockquote>
<br>
I moved starting of CA to the earlier phase and swapped start/stop
to correct order.<br>
<br>
Patch attached.<br>
</blockquote>
Seems to work as expected now. ACK.<br>
</body>
</html>