<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 27.05.2016 17:33, Nathaniel McCallum
wrote:<br>
</div>
<blockquote cite="mid:1464363234.3425.8.camel@redhat.com"
type="cite">
<pre wrap="">On Tue, 2016-05-24 at 12:25 -0400, Nathaniel McCallum wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Tue, 2016-05-24 at 11:01 -0400, Nathaniel McCallum wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Tue, 2016-05-24 at 16:55 +0200, Martin Kosek wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 05/24/2016 04:29 PM, Nathaniel McCallum wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Using a pragma instead of guards is easier to write, less error
prone
and avoids name clashes (a source of very subtle bugs). This
pragma
is supported on almost all compilers, including all the
compilers
we
care about: <a class="moz-txt-link-freetext" href="https://en.wikipedia.org/wiki/Pragma_once#Portabili">https://en.wikipedia.org/wiki/Pragma_once#Portabili</a>
ty
.
</pre>
</blockquote>
<pre wrap="">
Makes sense to me. I did not test, just saw a potential
typo/omission:
--- a/daemons/ipa-otpd/internal.h
+++ b/daemons/ipa-otpd/internal.h
@@ -20,9 +20,6 @@
* along with this program. If not, see <a class="moz-txt-link-rfc2396E" href="http://www.gnu.org/licenses/"><http://www.gnu.org/lic
en
se
s/></a>.
*/
-#ifndef INTERNAL_H_
-#define INTERNAL_H_
-
... no pragma there.
</pre>
</blockquote>
<pre wrap="">
Fixed.
</pre>
</blockquote>
<pre wrap="">
Here is a new version with a slightly edited commit message (just to
confirm that we don't edit the autogenerated files).
</pre>
</blockquote>
<pre wrap="">
Attached is a new version that is simply rebased on to master.</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
ACK<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<b style="font-weight:normal;"
id="docs-internal-guid-2ca01cc5-fc50-c9da-da0e-f19d92394c7a"><span style="font-size:14.666666666666666px;font-family:Arial;color:#000000;background-color:transparent;font-weight:400;font-style:normal;font-variant:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap;"></span></b>
<meta charset="utf-8">
Pushed to master: 4bafba06f2b8cc51cd95a725e1c8adf7bbf9a5fc<br>
<br>
</body>
</html>