<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Hi, thanks to Jan and Fraser for the review and the suggested error message. Please find the updated patch attached. Flo. <div class="moz-cite-prefix">On 06/02/2016 08:55 AM, Fraser Tweedale wrote: </div> <blockquote cite="mid:20160602065525.GG4744@dhcp-40-8.bne.redhat.com" type="cite"> <pre wrap="">On Thu, Jun 02, 2016 at 07:54:31AM +0200, Jan Cholasta wrote: </pre> <blockquote type="cite"> <pre wrap="">Hi, On 30.5.2016 19:58, Florence Blanc-Renaud wrote: </pre> <blockquote type="cite"> <pre wrap="">Hi all, this patch adds in the error message the missing certificate that caused i/pa-server-install --external-cert-file=.../ to fail. <a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5792">https://fedorahosted.org/freeipa/ticket/5792</a> </pre> </blockquote> <pre wrap=""> I think someone may confuse "issuer" with the "issuer name" field in the certificate, also IMO we should use "certificate" rather than "cert" in error messages, so I would rather use something like "missing certificate with subject '%s'" or maybe just "missing certificate '%s'". </pre> </blockquote> <pre wrap="">Let us be as specific as possible; Honza's suggestion "missing certificate with subject '%s'" is preferable. Cheers, Fraser </pre> </blockquote> <pre class="moz-signature" cols="72">-- Florence Blanc-Renaud Identity Management Team, Red Hat</pre> </body> </html>