<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 02.06.2016 09:41, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:95bd2879-5a64-b95e-19aa-b8a4b938ce39@redhat.com"
type="cite">
<br>
<br>
On 31.05.2016 14:10, Martin Basti wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 31.05.2016 14:08, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 05/31/2016 01:57 PM, Martin Basti
wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 31.05.2016 12:44, Martin Babinsky wrote:
<br>
<blockquote type="cite">On 05/28/2016 01:17 PM, Martin Basti
wrote:
<br>
<blockquote type="cite"><a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/4995">https://fedorahosted.org/freeipa/ticket/4995</a>
<br>
<br>
Patches attached
<br>
<br>
<br>
<br>
</blockquote>
<br>
Hi,
<br>
<br>
PATCH 0488: LGTM
<br>
<br>
PATCH 0489:
<br>
<br>
@@ -996,10 +997,10 @@ def check_deleted_segments(hostname,
masters,
<br>
topo_errors, starting_host):
<br>
i = 0
<br>
while True:
<br>
left = api.Command.topologysegment_find(
<br>
- suffix_name,
iparepltoposegmentleftnode=hostname,
<br>
sizelimit=0
<br>
+ suffix_name,
iparepltoposegmentleftnode=hostname,
<br>
sizelimit=0,
<br>
)['result']
<br>
right = api.Command.topologysegment_find(
<br>
- suffix_name,
iparepltoposegmentrightnode=hostname,
<br>
sizelimit=0
<br>
+ suffix_name,
iparepltoposegmentrightnode=hostname,
<br>
sizelimit=0,
<br>
)['result']
<br>
<br>
it seems that you added 'no_members=True' there and then
removed it
<br>
because reasons. Please revert the this part to the
original code so
<br>
that it does not stick out.
<br>
<br>
</blockquote>
<br>
Better (the right one) patches attached.
<br>
</blockquote>
<br>
ACK
<br>
<br>
</blockquote>
master:
<br>
* 91572afc60f590f0d81ad18234189a0b48144bf5 Make option
--no-members public in CLI
<br>
* 5f42b42bd4557a669ab5cfcf1af6596f1a2535f1 Performance: Find
commands: do not process members by default
<br>
<br>
</blockquote>
<br>
We found and issue, I used flag 'no_cli' instead of 'no_option'
<br>
<br>
fixed and pushed under oneliner rule
<br>
<br>
master:
<br>
* 5c58751d72de27eae2181f2c0e620df03f8dbc82 Fix: replace incorrect
no_cli with no_option flag
<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
I found another one-liner issue, there was extra no_members=False in
topologysuffix_find in replication.py, which caused error in
ipa-replica-manage<br>
<br>
Pushed to master: f077fab23fe9dc8a71562d1ba3c0d603d2957d3b<br>
<br>
</body>
</html>