<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 06/02/2016 07:18 PM, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:8ce7f9fe-ae8f-ed1e-f1b5-259e62030fae@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 30.05.2016 18:11, Florence
Blanc-Renaud wrote:<br>
</div>
<blockquote
cite="mid:93631e86-725f-ba0e-ce17-6e8b99325f23@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p>Hi Martin,</p>
<p>thanks for the review and the suggestion. Please find the
updated patch attached.<br>
</p>
Flo.<br>
<br>
<div class="moz-cite-prefix">On 05/30/2016 11:00 AM, Martin
Basti wrote:<br>
</div>
<blockquote
cite="mid:7c482bfd-c466-a2c9-ca29-bcd2a28163df@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 27.05.2016 11:35, Florence
Blanc-Renaud wrote:<br>
</div>
<blockquote
cite="mid:aeac2b6d-e49d-3ca0-0da9-d1746c217f45@redhat.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<p><font size="-1">Hi all,</font></p>
<p><font size="-1">this patch adds information to the output
of ipa-client-install when it fails due to invalid
format in a configuration file:<br>
ipa-client-install failing with SyntaxError: Syntax
Error: Unknown line format</font></p>
<p><font size="-1">Fixes: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5811">https://fedorahosted.org/freeipa/ticket/5811</a></font></p>
<pre class="moz-signature" cols="72">--
Florence Blanc-Renaud
Identity Management Team, Red Hat</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Thank you for your patch, I have just one nitpick. Can you
please reuse the original exception?<br>
<br>
- curopts.append(self.parseLine(line))<br>
+ try:<br>
+ curopts.append(self.parseLine(line))<br>
+ except SyntaxError as e:<br>
+ raise SyntaxError('{error} in file {fname}:
[{line}]'.format(<br>
+ error=e, fname=f.name, line=line))<br>
<br>
Martin^2<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Florence Blanc-Renaud
Identity Management Team, Red Hat</pre>
</blockquote>
<br>
<br>
We are almost there<br>
<br>
SyntaxError: Syntax Error: Unknown line format in file
/etc/nsswitch.conf: [sudoers sss<br>
]<br>
<br>
I don't like that extra newline, probably we should use
line.rstrip() to line, to remove any whitespaces on right side,
I'm not sure about left side, it probably should stay with
whitespaces<br>
<br>
Martin^2<br>
</blockquote>
<br>
Hi Martin,<br>
good catch. Please find the updated patch attached.<br>
<pre class="moz-signature" cols="72">--
Florence Blanc-Renaud
Identity Management Team, Red Hat</pre>
</body>
</html>