<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hello,</p>
<p>Thank you for your patch. As the thin-client patches were pushed
in the meantime, the patch won't apply. Could you please send a
rebased version?</p>
<p>Also, I have a few comments to the patch:</p>
<p>1) I think that the commit message should be rather a brief
conclusion to the changes made in the commit. This could help for
faster orientation in the changes that were made to a certain part
of code should you be searching for a bug introduced by a commit.
Should some more info be required, it can be added to the ticket.
Could you therefore shorten the commit message?<br>
</p>
<p>2) Please do not add the tickets to comments in the code. You can
use git blame -L or git log -L to see in which commits were the
changes introduced to a certain part of a file, these commits
should include the ticket number if more info is needed.</p>
<p>Standa<br>
</p>
<br>
<div class="moz-cite-prefix">On 05/27/2016 03:53 PM, Florence
Blanc-Renaud wrote:<br>
</div>
<blockquote
cite="mid:6b54d58e-58c5-02a7-d6fb-6f370ab14770@redhat.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<p>Hi all,</p>
<p>the following patch checks the format of parameters passed to a
method called through the batch command. I picked the
ConversionError for invalid parameters format but this choice
can be discussed if you have better suggestions...<br>
</p>
Fixes: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5810">https://fedorahosted.org/freeipa/ticket/5810</a><br>
<pre class="moz-signature" cols="72">--
Florence Blanc-Renaud
Identity Management Team, Red Hat</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
</body>
</html>