<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/09/2016 10:15 AM, Pavel Vomacka
wrote:<br>
</div>
<blockquote
cite="mid:e3e2b440-0482-3943-30bb-16b32d468b22@redhat.com"
type="cite">
<br>
<br>
On 06/08/2016 04:40 PM, Petr Vobornik wrote:
<br>
<blockquote type="cite">On 06/07/2016 10:07 AM, Pavel Vomacka
wrote:
<br>
<blockquote type="cite">
<br>
On 06/06/2016 07:51 PM, Martin Basti wrote:
<br>
<blockquote type="cite">
<br>
<br>
On 05.06.2016 18:34, Pavel Vomacka wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
please review attached patches which add WebUI part of DNS
Locations feature.
<br>
<br>
-- <br>
Pavel^3 Vomacka
<br>
<br>
<br>
</blockquote>
NACK
<br>
<br>
1)
<br>
When I edit location description and click on revert button,
then that nice
<br>
location table just disappear :)
<br>
</blockquote>
It's the same situation as with using 'Save' button - reported
here:
<br>
<a class="moz-txt-link-freetext" href="https://fedorahosted.org/freeipa/ticket/5776">https://fedorahosted.org/freeipa/ticket/5776</a> . I'll write
there a comment that
<br>
revert button hides values in association tables.
<br>
<blockquote type="cite">2)
<br>
Can we put a placeholder "100" (gray font or something) to
Location weight in
<br>
server detail view? Because when weight is not specified
then default is 100
<br>
</blockquote>
Placeholder added.
<br>
<br>
</blockquote>
<br>
1. please add "disable_facet_tabs: true," to location details
page.
<br>
There is no point to display single facet tab.
<br>
</blockquote>
Fixed.
<br>
<blockquote type="cite">2. can we extend
location_association_table the same witth as rule
<br>
tables are extended in sudo and hbac rules? IIRC it needs to use
<br>
specific section type of 'servers' section.
<br>
</blockquote>
Fixed.
<br>
<blockquote type="cite">
<br>
3. the placeholder 100 should be also added to adder dialog in
<br>
location_association_table_widget
<br>
</blockquote>
I think that it can be confusing when user tries to move a server
from one location to another, because server might have set a
weight already and it can differ from 100. In this case user would
see placeholder 100 but in reality the weight of server would be
different (value set in previous location).
<br>
<blockquote type="cite">4. Description could be textarea - to be
consistent with hbac, sudo rules.
<br>
</blockquote>
Fixed.
<br>
<blockquote type="cite">
<br>
5. "Information" section is called "General" or "$Entity
Settings" on
<br>
other parts of Web UI. It should be consistent.
<br>
</blockquote>
Fixed.
<br>
<br>
Patches attached.
<br>
<br>
--
<br>
Pavel^3 Vomacka
<br>
<blockquote type="cite">
<br>
<br>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Another revision of patch 40, removed useless comma from
ipa_init.json. Both patches attached.<br>
</body>
</html>