<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 09.06.2016 14:31, Stanislav Laznicka
wrote:<br>
</div>
<blockquote
cite="mid:00b53128-3e52-4d2e-3fbc-731ea96e7f44@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
On 06/09/2016 11:58 AM, Florence Blanc-Renaud wrote:<br>
<blockquote
cite="mid:ba2e230f-d98e-f499-5a3f-1c9f0d369db5@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/08/2016 01:14 PM, Stanislav
Laznicka wrote:<br>
</div>
<blockquote
cite="mid:dbb70487-18c6-490f-2274-dd25d08fd26a@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
On 06/08/2016 01:13 PM, Stanislav Laznicka wrote:<br>
<blockquote
cite="mid:563432e8-aac2-2bc3-c290-ab56a3a5f684@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 06/07/2016 05:11 PM,
Florence Blanc-Renaud wrote:<br>
</div>
<blockquote
cite="mid:7f1f1c03-6320-da3f-0c01-65954d28a148@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div class="moz-cite-prefix">On 06/07/2016 04:08 PM,
Stanislav Laznicka wrote:<br>
</div>
<blockquote
cite="mid:ec6f79c6-5671-dd2f-712e-733d968954fe@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
On 06/06/2016 02:47 PM, Florence Blanc-Renaud wrote:<br>
<blockquote
cite="mid:2646f4ce-dfe2-4916-e8e1-f86bfbd118b3@redhat.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<p><font size="-1">Hi,</font></p>
<p><font size="-1">please find attached the patch for
Ticket 5434 add context to exception on LdapEntry
decode error<br>
</font></p>
<p><font size="-1"><a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5434">https://fedorahosted.org/freeipa/ticket/5434</a></font><br>
</p>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<p>Hello,</p>
<p>Similarly to you patch 0003, could you please shorten
the commit message? I appreciate that you added the
way to reproduce the bug but I would rather see it in
the comments of the ticket.</p>
<p>I haven't tested the patch yet but I think that the
try-except block should also wrap the <tt>self._conn.decode</tt>
in the <tt>raw_dels</tt> loop:</p>
<p><tt> 310 for value in raw_dels:</tt><tt><br>
</tt><tt> 311 value =
self._conn.decode(value, name)</tt><tt><br>
</tt><tt> 312 if value in nice_adds:</tt><tt><br>
</tt><tt> 313 continue</tt><tt><br>
</tt><tt> 314 nice.remove(value)</tt></p>
<p>Standa<br>
</p>
</blockquote>
<p>Hi Standa,</p>
<p>thanks for your review. I will shorten the commit
message as you suggested.</p>
<p>Regarding the other decode() called for raw_dels, I was
not sure in which case this part of the code was called.
Do you happen to know if it possible for an invalid
value to be in the raw_sync list but not in the raw
list?</p>
<p>Flo.<br>
</p>
</blockquote>
I'm not sure if there's an easy way to do that. I would just
put it there should it ever occur to have more information
about what happened.<br>
</blockquote>
Forgot to include devel-list, sorry.<br>
</blockquote>
<p><font size="-1">Hi,</font></p>
<p><font size="-1">updated patch attached.</font></p>
<p><font size="-1">Flo.</font><br>
</p>
</blockquote>
Thank you for the updated patch. It seems to work as expected so
ACK.<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
Pushed to master: 53524fbbff51418a8f1194c8559c9dcfcc5bbb83<br>
<br>
</body>
</html>