<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi All,<br>
<br>
Please review updated patch.<br>
<br>
<div class="moz-cite-prefix">On 06/15/2016 07:56 PM, Abhijeet
Kasurde wrote:<br>
</div>
<blockquote cite="mid:576165A6.9050801@redhat.com" type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 06/15/2016 07:29 PM, Martin Basti
wrote:<br>
</div>
<blockquote
cite="mid:25ad2f38-ede8-bcf9-b554-6b07803e2981@redhat.com"
type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 15.06.2016 11:13, Abhijeet
Kasurde wrote:<br>
</div>
<blockquote cite="mid:57611C1E.8090000@redhat.com" type="cite">Hi
All, <br>
<br>
Please review the attached patch. <br>
<br>
Fixes: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://fedorahosted.org/freeipa/ticket/5920">https://fedorahosted.org/freeipa/ticket/5920</a>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
Thank you for the patch, <br>
<br>
Please follow this page for howto create internationalized
strings:<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://www.freeipa.org/page/Python_Coding_Style#Python_Internationalized_.28i18n.29_Strings">http://www.freeipa.org/page/Python_Coding_Style#Python_Internationalized_.28i18n.29_Strings</a><br>
<br>
you must use named subsitution, because translators may need to
know what should be there, or they may change the order of words
depending on translated language<br>
<br>
Martin^2<br>
</blockquote>
<br>
Thanks Martin for suggestion. I will implement this in current
patch and re-submit it for code review.<br>
<br>
<pre class="moz-signature" cols="72">--
Thanks,
Abhijeet Kasurde
IRC: akasurde
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://akasurde.github.io">http://akasurde.github.io</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Thanks,
Abhijeet Kasurde
IRC: akasurde
<a class="moz-txt-link-freetext" href="http://akasurde.github.io">http://akasurde.github.io</a>
</pre>
</body>
</html>